Should this be in devDependencies ?
Closed this issue · 3 comments
Overtorment commented
I have a project that works fine, with rn-nodeify sitting in devDependencies
.
I tried to do npm install --production
and got:
> rn-nodeify --install buffer,events,process,stream,util,inherits,fs,path --hack
sh: 1: rn-nodeify: not found
(I have rn-nodeify in my postinstall
script)
How is this supposed to work for production builds?
Overtorment commented
oh and the real problem is that ./gradlew assembleRelease
fails with
error Unable to resolve module `stream` from `node_modules/cipher-base/index.js`: stream could not be found within the project.
mvayngrib commented
npm install --production
is a harder to get working in environments where building is a necessary step before running. If you really want to use npm install --production
, why not just move rn-nodeify to dependencies?
oh and the real problem is that ./gradlew assembleRelease fails with
that's because rn-nodeify didn't get to run :)
Overtorment commented
thanks! that's what I thought but decided to ask just for any case.