CpGindex breaks when hypoMeth and hyperMeth have different sizes
Closed this issue · 2 comments
jamorrison commented
Using chr11p15 (for reducing computation time), the hypoMeth and hyperMeth arrays have different sizes. This becomes an issue when trying to calculate the ratio between them, as R can't conform the arrays to one another.
Should the ratio be included? Or, can it be removed and left up to the user to calculate the ratio on their own if they decide they want to do that?
ttriche commented
Hmmm -- the ratio really ought to be (hypermeth * bp) / (hypometh * bp) as rates across aggregated regions, so it seems like a bug if array conformation is breaking this.
…--t
________________________________________
From: jamorrison <notifications@github.com>
Sent: Wednesday, September 11, 2019 10:32 AM
To: trichelab/biscuiteer
Cc: Subscribed
Subject: [trichelab/biscuiteer] CpGindex breaks when hypoMeth and hyperMeth have different sizes (#19)
Using chr11p15 (for reducing computation time), the hypoMeth and hyperMeth arrays have different sizes. This becomes an issue when trying to calculate the ratio between them, as R can't conform the arrays to one another.
Should the ratio be included? Or, can it be removed and left up to the user to calculate the ratio on their own if they decide they want to do that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#19?email_source=notifications&email_token=AAABCIVARFUCVKEIVCR7D6TQJD6RPA5CNFSM4IVU2DO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKXRWXA>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAABCISWE2AYCBQE4URT2QTQJD6RPANCNFSM4IVU2DOQ>.
jamorrison commented
Closing issue since it was resolved - there was a bug where the vector multiplication was an outer product instead of a dot product. This has since been fixed.