Move term adding function to the install

Question

Move term adding function to the install

almasaeed2010 opened this issue 6 years ago · 3 comments

almasaeed2010 commented 6 years ago

We currently generate the term insertion code in the .fields.inc file but the badges guideline specifically asks for this to be in the install file. Would a simple comment suffice? Or do we need to create a new file for it?

Answer 1 · 2019-03-08T13:56:50.000Z

This is contradictory with what Stephen has told me which is that the vocab should be with the fields so they are portable. Let’s double check

…

Sent from my iPhone

On Mar 8, 2019, at 8:36 AM, Abdullah Almsaeed ***@***.***> wrote: We currently generate the term insertion code in the .fields.inc file but the badges guideline specifically asks for this to be in the install file. Would a simple comment suffice? Or do we need to create a new file for it? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 2 · 2019-03-08T13:58:34.000Z

Point 4 https://tripal.readthedocs.io/en/latest/extensions/module_rating.html#bronze

Answer 3 · 2019-03-08T14:00:06.000Z

It makes sense to add them in the install file since we don't want all fields to attempt to add their terms again with every time cache is cleared.