Add support for TLS with cert-manager
andrestc opened this issue · 4 comments
We added support for nginx + tls using kube-lego and its annotations in #11. Kube-lego is now deprecated and only supported in Kubernetes up to 1.8.x. We should add support for tls using cert-manager, which is the official replacement for kube-lego: https://github.com/jetstack/cert-manager/.
I've updated to cert-manager and update nginx-ingress (which already supports cert-manager).
The annotations are still the same for it:
kubernetes.io/tls-acme: true
But the point is that we have a few new annotations that can be used (besides the basic):
I would say that certmanager.k8s.io/issuer and certmanager.k8s.io/cluster-issuer are nice ones to have handled by kubernetes-router.
Actually you can assign to me. =)
Look good. Maybe we can support receiving these as custom router options as well.
Sure, I will create a PR soon.