tunnckoCore/parse-function

support for generator functions and async functions

ORESoftware opened this issue · 5 comments

ORESoftware commented

Loving this lib so far, but it appears that it is not currently configured to parse generator functions and async functions

function*

and async functions

async function(){

}

can this be confirmed and do you plan to update it if so? thanks!

tunnckoCore commented

Which version you use? It should work for generator functions (im not sure) because v2.3.x is on top acorn.

I'll check and add tests ASAP, or you can PR some tests :)

tunnckoCore commented

@ORESoftware use v2.3.x if you need advanced things - it have full support for what acorn can do. The other versions not uses acorn so things like that are hard and not handled.

If you just need to get arguments/parameters use v2.0.x it is much faster.

ORESoftware commented

Thanks yeah I need to parse ES7 functions - async functions and generators* - it looks like you use / acorn uses ES7 parsing by default. I am not concerned about speed- I just need reliability for this

tunnckoCore commented

@ORESoftware yea i forced ES7, acorn's default is ES6 (meaning acorn ecmaScript default is 6, parse-functions force it to 7) :)

Thanks using it!

ORESoftware commented

yeah it's working for me so far