twbs/bootstrap

`kbd` styles

zlatanvasovic opened this issue · 7 comments

zlatanvasovic commented

It would be nice to have default kbd styles that really looks like keyboard button, but please not like buttons.

kbd is very useful element for documentation, and it's nice for keyboard shortcuts.

mdo commented

Are you thinking of using the element as the selector, or writing a new class to support this?

zlatanvasovic commented

kbd selector is enought. Maybe additional class (like .kbd) would be nice, but it isn't really needed.

zlatanvasovic commented

Hey. I found enought styles for this:

@kbd-bg: #f5f5f5;
@kbd-border: #ccc;
@kbd-border-bottom: #aaa;

kbd {
  padding: @padding-base-vertical @padding-base-horizontal;
  background-color: @kbd-bg;
  border: 1px solid @kbd-border;
  border-bottom: 1px solid @kbd-border-bottom;
  border-radius: @border-radius-base;
}

Variable values can be changed, but I think that this is enought styles (border, padding, border-radius, background). Thoughts?

zlatanvasovic commented

@mdo Will the pull request help?

mdo commented

@zdroid Nah, I can do this when we're ready. We can't (shouldn't?) do it now though because technically it's a new feature, and new features shouldn't be part of a patch release. We'll have to do it for 3.1.

zlatanvasovic commented

Right (I didn't thought about publishing it in 3.0.1).

2013/10/27 Mark Otto notifications@github.com

@zdroid https://github.com/ZDroid Nah, I can do this when we're ready.
We can't (shouldn't?) do it now though because technically it's a new
feature, and new features shouldn't be part of a patch release. We'll have
to do it for 3.1.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11193#issuecomment-27164584
.

Zlatan Vasović - ZDroid

zlatanvasovic commented

Thanks.