uber/neuropod

NOTICE: Intent to upgrade to C++14

Closed this issue · 1 comments

Neuropod is currently built with C++11

There are lots of nice C++ features between 11 and 17

Many of our other internal tools and libraries at ATG also use C++17 so it would be nice to upgrade for consistency.

Also Torch 1.5.0 requires C++14 (so we need to upgrade anyway for at least the Torch 1.5 builds)

PyTorch 1.4 is the last release that supports Python 2. For the C++ API, it is the last release that supports C++11: you should start migrating to Python 3 and building with C++14 to make the future transition from 1.4 to 1.5 easier.

Please comment below if you have any concerns about this

Upgraded to C++14 in #350. Will explore C++17 in the future because this gets tricky with building in a manylinux2014 syroot