Dimension of BEL_WATT and BEL_KILOWATT is wrong
frank-montyne opened this issue · 4 comments
frank-montyne commented
The dimension of BEL_WATT and BEL_KILOWATT should be level of power instead of level of electric potential.
It is stated correctly in the comments but wrongly defined:
/** power level */
public static final Unit<Level<ElectricPotential>> BEL_WATT = addUnit(
WATT.transform(new LogConverter(10)).asType(Level.class));
public static final Unit<Level<ElectricPotential>> BEL_KILOWATT = addUnit(
KILO(WATT).transform(new LogConverter(10)).asType(Level.class));
should be:
public static final Unit<Level<Power>> BEL_WATT = addUnit(
WATT.transform(new LogConverter(10)).asType(Level.class));
public static final Unit<Level<Power>> BEL_KILOWATT = addUnit(
KILO(WATT).transform(new LogConverter(10)).asType(Level.class));
keilw commented
Seems a copy/paste mistake from BEL_VOLT. Thanks for spotting that. You are welcome to create a PR if you can, otherwise we plan to fix that with the 2.1 release train which is supposed to follow that of the main JSR deliverables like API, RI or TCK in Q4.
frank-montyne commented
I just created a PR.
…On Mon, Oct 26, 2020 at 1:50 PM Werner Keil ***@***.***> wrote:
Seems a copy/paste mistake from BEL_VOLT. Thanks for spotting that. You
are welcome to create a PR if you can, otherwise we plan to fix that with
the 2.1 release train which is supposed to follow that of the main JSR
deliverables like API, RI or TCK in Q4.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJKQL3G6UHKWZ5WDURSSZTSMVWAHANCNFSM4S6HLS7Q>
.
keilw commented
I'll check it out, thanks. Especially in UCUM we have a contributors file, would you like to be mentioned there?
frank-montyne commented
Maybe next time, this was a really small thing...
Best regards,
Frank
… On 26 Oct 2020, at 16:46, Werner Keil ***@***.***> wrote:
I'll check it out, thanks. Especially in UCUM we have a contributors file, would you like to be mentioned there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.