Tournament Display shows "Rated On" as "--" for all tournaments.
Closed this issue · 5 comments
Recommend changing "Rated On" to "Rated ?" or "Rated Y/N".
Reason: just got results for Simsbury played on 2013-03-02.
Rated it on 2013-03-29. All tournaments from that same date or lated where rerated as a result. Should "Rated On" be the first time rated?, the last time rated? or the most recent time rated?
"Rated Y/N" should be based upon
"select distinct g.Tournament_Code from games g where g.Rated = 1;"
how about "rated on" = "rated y/n" where "rated" = "subsumed into the borg."
On Fri, Mar 29, 2013 at 7:32 AM, Jonathan Bresler
notifications@github.comwrote:
Recommend changing "Rated On" to "Rated ?" or "Rated Y/N".
Reason: just got results for Simsbury played on 2013-03-02.
Rated it on 2013-03-29. All tournaments from that same date or lated where
rerated as a result. Should "Rated On" be the first time rated?, the last
time rated? or the most recent time rated?"Rated Y/N" should be based upon
"select distinct g.Tournament_Code from games g where g.Rated = 1;"—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23
.
Andrew,
Dont understand what you mean.
Suggest replacing the text "Rated on" which suggests a date
with "Rated Y/N" which does not suggest a date
due to the fact that tournament results are rated as available
not in the order in which the tournament was played.
As a result a tournament first rated on 3/29/2013 will be re-rated
if an earlier tournament, such as 3/15/2013, arrives and is rated after
3/29/2013.
What date should "Rated on" show in that case ?
So, let's change the text to "Rated Y/N"
Jonathan
On Fri, 29 Mar 2013, Andrew Jackson wrote:
how about "rated on" = "rated y/n" where "rated" = "subsumed into the borg."
On Fri, Mar 29, 2013 at 7:32 AM, Jonathan Bresler
notifications@github.comwrote:Recommend changing "Rated On" to "Rated ?" or "Rated Y/N".
Reason: just got results for Simsbury played on 2013-03-02.
Rated it on 2013-03-29. All tournaments from that same date or lated where
rerated as a result. Should "Rated On" be the first time rated?, the last
time rated? or the most recent time rated?"Rated Y/N" should be based upon
"select distinct g.Tournament_Code from games g where g.Rated = 1;"—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23
.
Reply to this email directly or view it on GitHub:
#23 (comment)
Sorry, coming back to this from a bit of a break.
From looking at the schema, it looks like the tournaments have both a "tournament_date" and a "elab_date". My assumption was that the elab_date marks the day that they've been entered into the database, and the tournament date is the date the tournament was actually played. Is that correct?
Happy to base the rated y/n on your query but seems a bit less efficient than just using the elab_date field, if it's used for same.
Tables.py lists the following for the main code for what are the latest tournaments:
class TournamentTable(tables.Table):
tournament_code = tables.LinkColumn(
'agagd_core.views.tournament_detail',
kwargs={'tourn_code':tables.A('tournament_code')},)
elab_date = tables.Column(verbose_name="rated on")
class Meta:
model = Tournament
attrs = {"class": "paleblue"}
fields = ("tournament_code", "description", "tournament_date", "city", "state", "total_players", "rounds", 'elab_date')
sequence = fields
The code is looking for the 'elab_date' code within the usgo_agagd.tournaments table. This field is has no values within that table and only lists as 0000-00-00. This table also has no column for "rated".
The table that needs to be looked at is in usgo_agagd.games table is either the 'rated' field which is either 0/1. This table also updates the 'elab_date' table and has current dates for when it was rated on.
The code for this table on the page will need to reference both the "tournaments" table and the "games" table as the information is different. "Tournaments" references the recent/full list of tournaments we have tracked. "Games" is the full list of individual games and when they have been played/results/players/rated information. Both tables reference 'tournament_code' column which can compare the tournament with the rated on information.
This was resolved as for a PR listed here: usgo/AGA-Ratings-Program#3
Tested and working on the test site. Merged into code.