update-comment true not working

Question

update-comment true not working

Closed this issue 3 years ago · 7 comments

ricardovanlaarhoven commented 3 years ago

- name: report coverage based on jest
        uses: vebr/jest-lcov-reporter@v0.2.0
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          update-comment: true

I've changed update-comment a while ago from false into true and the comments even from new PR's are still not updated.

Perhaps this is the same (but opposite) issue as #21

Answer 1 · 2021-09-02T14:06:43.000Z

Warning: Unexpected input(s) 'update-comment', valid inputs are ['github-token', 'lcov-file', 'lcov-base']

Answer 2 · 2021-10-05T06:16:17.000Z

The latest release github action failed, that release included this feature. Please take a look into that.
i'd love to help but i cant check the logs or run the command

@alexjfno1 Perhaps you could take a look?

Answer 3 · 2021-10-05T07:59:24.000Z

@ricardovanlaarhoven I'll update and see if I can reproduce

Answer 4 · 2021-10-05T13:10:10.000Z

#21 (comment)
The weird thing is that your comment there would mean that it's really weird that my action is always creating a new comment
and that message: Unexpected input(s) 'update-comment'

Answer 5 · 2021-10-06T08:44:54.000Z

@ricardovanlaarhoven the action will always create a comment weather you specify update-comment or not. update-comment just means that if you push another commit to the PR it'll replace the existing comment with an updated one instead of creating a new one.

Answer 6 · 2021-10-06T08:46:05.000Z

@ricardovanlaarhoven can I just check that you're on the latest version?

uses: vebr/jest-lcov-reporter@v0.2.1

Answer 7 · 2021-10-06T12:42:58.000Z

I was using 0.2.0, thanks!