[ISSUE] Initiative auto roll npcs doesnt work on pf2 correctly
ThingsCouldGetDicey opened this issue · 20 comments
Describe the bug
pf2 has an auto roll of npcs hook by shift clicking the npcs in the combat tracker. currently when using the feature to auto roll npcs in the system will pull up roll dialogues for each npc forcing the user to click all of the manually.
To Reproduce
Steps to reproduce the behavior:
- enable npc auto roll within a pf2 system game
- have alot of npcs
- start combat
- See all of the dialogue rolls.
Expected behavior
what i expect to replace the current behaviour is just to auto roll the intiative without the dialogue with the assumed perception skill.
Screenshots
If applicable, add screenshots to help explain your problem.
Version Information
- Quick Combat: Current
- FoundryVTT: Current
- System:PF2e
- Other Modules:
Additional context
Add any other context about the problem here.
ive added a new setting for quick combat (https://github.com/veevelder/quick-combat#pathfinder-second-edition---skip-dialog) that should take care of what you want. Let me know if there is anything else you would like to add for PF2e
i mean if you can do it we are looking for a solution to being able to select the kind of intiative before combat starts. so a selection box of the skill checks for intiative would be amazing.
I can look into it, but I just want to clarify a few things as im not to familiar with PF2e.
Is the type of initiative the same for all PCs/NPCs, or can they be different?
Is this something a player should determine or just the GM?
If I cant find a "simple" solution I can monitor the issue you linked to see if they make any updates and adjust my stuff as needed.
I can look into it, but I just want to clarify a few things as im not to familiar with PF2e.
Is the type of initiative the same for all PCs/NPCs, or can they be different? Is this something a player should determine or just the GM?
If I cant find a "simple" solution I can monitor the issue you linked to see if they make any updates and adjust my stuff as needed.
the gm detemines the roll. based on what the pcs or npcs where doing prior to the call for intiative. the default is perception based checks. as thats the most common the second common is stealth rolls. the idea being that if they roll higher with stealth they get to go first in initiative. there are no surprise rounds. but for example if a pc wanted to bluff his way to get closer to an npc the intiative roll would be deception instead of the usual perception skill. this also could be different per pc and per npc. depending on what they were doing prior. but the most common is perception and stealth.
which is why if you can do something to contribute to the system that did add the intaitive selection on the roll dialogue or something that could ask the gm "hey do you wanna roll X skill for all npcs" that would be a good solution for the most part.
Ok, so I think I may have a solution to this, I haven't pushed into the code base yet but here is what it will look like.
New setting to Group NPC rolls by initiative type
When enabled it will pop up a new window to select which skill to roll with
This will enable all NPCs to use that skill to roll for initiative but still ask for the PCs (the window will still pop up).
(the 1 actor is the PC)
Obviously with this option disabled it will still popup the windows for every combatant. After you've selected the skill to roll with normal quick-combat stuff will happen. So does this work for your needs or do you have something else in mind?
usually it will be either perception as default or stealth for npcs. for players its more vital to have the selection. for that pop up. it will be much rarer for npcs to need other checks. but for players its more frequent. if they could click the intiative roll button on the combat tracker and for that drop down menu to happen for them that would be very useful to players.
Ok, how does this look then? (GM on left player on right)
The GM initiates combat a pop up will display for him asking for the type
It will then ask the players for the type
and once all players have submitted it will roll and start combat
this looks amazing. have you shared this with the pf2 devs?
could you post a gif of this working so i could see it in action?
Here is a gif of it working, sorry for the terrible quality.
cool i would have an option to enable gms to individually select each npc for a box selection too and with a short cut to bypass group selection when grouping them just incase. as this may come up in the future. then i think its sorted.
ok how does this look then? New Settings Option to choose from
Default - system default it will prompt for every combatant
Fast - will assume Perception for every combatant, and wont prompt
Prompt - will prompt GM and Players to pick which initiative type to roll with
- GM will have an NPC prompt to either Group NPCs types OR pick individual initiative type
that is amazing! better than i expected. maybe one more option fast for gm (i.e always rolling perception) prompt for players? but what youve done for prompt is how id use it.
so the way i understand it you get the prompt at the top to group npcs to whatever that box is but if you wanted to individualise it you could by unselecting it and doing it manually right?
I can add that option.
and yeah, if you have that checkbox selected it will roll whatever you have selected in the drop down for every NPC.
however if you uncheck that checkbox, for each NPC listed below it will roll whatever you have in their drop downs
also intaitive rolls shouldnt default to blind. they should be public rolls. just to be clear.
there maybe an instance where the gm may want to roll in secret. so you could put in a clause when the gm rolls stealth for inatiative. its a non public roll. not even blind because the gm wouldnt want the players to see the dice. then all bases are covered.
I don't think the pf2e system will let me set the chat output options, but if the GM sets the roll type before rolling it will be set for all the rolls, so they can use it to set public/private rolls in that case. I can set things as secret but that doesn't appear to be the same thing.
without secret public rolls
with secret rolls public rolls
players view
im inclined to leave it as is with the secret rolls enabled and the GM can reveal them whenever they want to. In reality it doesnt make that much of a difference when looking at the turn tracker (except for hidden tokens). And adding more buttons to things that should be automated feels like taking a step backwards.
fair enough just wanted to make sure all bases are covered. you have done a fantastic job.
the module has been updated, let me know if you find an issues with it