venmo/Static

Question about refreshTableSections:oldSections and row insertion animations

Opened this issue · 0 comments

First, thanks for sharing this framework, its really great!

Have a question for you all. I was looking into the code framework to see how it would be the best way to animate the rows insertions and found that there is a private method called refreshTableSections:oldSections, with a default argument nil.
This functions has a guard statement that always calls reloadData() if the argument is nil.

All the places that call refreshTableSections in the framework call it with the default argument nil, never passing the oldSections. So the function never runs completely and as a private function I can't cal it from outside.

It this right? how can i refresh only some rows, to animate insertion?

Thanks!

private func refreshTableSections(oldSections: [Section]? = nil) {
        guard let tableView = tableView else { return }
        guard let oldSections = oldSections else {
            tableView.reloadData()
            return
        }
        ...

Thanks! 👍