versotile-org/verso

keyboard: support all key conversions

Opened this issue · 2 comments

pewsheen commented

Follow up from #67

Super, Capslock are not recognized by the webview.

wusyong commented

I think this is simply because we haven't supported all key conversions. We can use this issue as feature request to add more key supports.

  • 👍1
wusyong commented

There are three methods that haven't supported all conversions yet:

verso/src/keyboard.rs

Line 20 in a64b679

fn get_servo_key_from_winit_key(key: &LogicalKey) -> Key {

verso/src/keyboard.rs

Line 120 in a64b679

fn get_servo_location_from_physical_key(physical_key: PhysicalKey) -> Location {

verso/src/keyboard.rs

Line 150 in a64b679

fn get_servo_code_from_physical_key(physical_key: PhysicalKey) -> Code {

Feel free to open PR to add some conversions. We can add this step by step. Perhaps we can also open more issues to list out missing keys.