Refactor code in background.js

Question

Refactor code in background.js

vinitshahdeo opened this issue 5 years ago · 12 comments

vinitshahdeo commented 5 years ago

Please check background.js and refactor the different methods inside this.
Do small, incremental changes that leave the code in a better state than it was found.
Do not make any changes in other files.
Make sure that the existing functionality shouldn't break.

Answer 1 · 2019-10-10T21:07:54.000Z

i will do this

Answer 2 · 2019-10-11T05:21:31.000Z

Is anyone assigned to this issue? I would like to participate if possible!

Answer 3 · 2019-10-11T05:54:28.000Z

@aleoof Yes, please go ahead.

Answer 4 · 2019-10-11T05:55:05.000Z

@JordanRosas No actually, give it a shot, I'll merge the most optimized code.

Answer 5 · 2019-10-11T12:53:35.000Z

Hi @vinitshahdeo last night I ran your project fresh and and when I opened my devtools I got three errors

A bad HTTP response code (404) was received when fetching the script.
background.js:174 Uncaught TypeError: Cannot read property 'get' of undefined
at setCookieCount (background.js:174)
at background.js:180 (Don't mind the line numbers I had my refactored code sitting on top of the old code for reference)
GET http://127.0.0.1:8080/index.js net::ERR_ABORTED 404 (Not Found)

is there something I am missing on my end?

Answer 6 · 2019-10-11T13:01:12.000Z

@JordanRosas It seems you opened index.html in chrome directly. It's a chrome extension so it's supposed to be installed locally. Please refer this.

Answer 7 · 2019-10-11T14:00:43.000Z

Hi Again! Pardon my many questions I've never worked with a chrome extension. I tried to load the unpacked extensions from the instructions in hour README and I get a Filed to load extension with the following message => Cannot load extension with file or directory name _config.yml. Filenames starting with "_" are reserved for use by the system. Could not load manifest. Any Ideas?

…

On Fri, Oct 11, 2019 at 8:01 AM Vinit Shahdeo ***@***.***> wrote: @JordanRosas <https://github.com/JordanRosas> It seems you opened index.html in chrome directly. It's a chrome extension so it's supposed to be installed locally. Please refer this <https://developer.chrome.com/extensions/getstarted>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AH3LLVR3ZBTF7UOXTL4VZELQOB2JTA5CNFSM4I7R5RIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA75P4A#issuecomment-541054960>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3LLVVE2QWLBCPSQAG3ZK3QOB2JTANCNFSM4I7R5RIA> .

Answer 8 · 2019-10-11T14:05:46.000Z

@JordanRosas My bad. Please delete that file (_config.yml). It's not supposed to be there. This for GitHub pages.

Answer 9 · 2019-10-11T14:09:13.000Z

Awesome thanks.

…

On Fri, Oct 11, 2019 at 9:05 AM Vinit Shahdeo ***@***.***> wrote: @JordanRosas <https://github.com/JordanRosas> My bad. Please delete that file (_config.yml). It's not supposed to be there. This for GitHub pages. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AH3LLVTZA4TOUY5VZKF7EKLQOCB3VA5CNFSM4I7R5RIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBADKMY#issuecomment-541078835>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3LLVWUOOPXTOKAVOA2ABTQOCB3VANCNFSM4I7R5RIA> .

Answer 10 · 2019-10-11T14:59:26.000Z

@JordanRosas You're welcome!

Answer 11 · 2019-10-11T21:36:41.000Z

@vinitshahdeo I have a PR up for some reason I couldnt add you as a reviewer?

Answer 12 · 2019-10-11T21:50:07.000Z

@JordanRosas No problem. Thank you for the PR. I'll review and merge it soon.

You may look into a few more good first issues here which are up for grabs!