visjs/angular-visjs

Hooking network click event causes exception

Tooa opened this issue ยท 5 comments

Tooa commented

Hi ๐Ÿ‘‹,

hooking the network click event causes an exception. To get rid of the problem remove the following unnecessary code:

scope.$watch('events', function (events) {
       angular.forEach(events, function (callback, event) {
           if (['select', 'click', 'hoverNode', 'doubleClick'].indexOf(String(event)) >= 0) {
                 network.on(event, callback);
            }
      });
 });

The problem originates from the change in #33.

Hi,
Iโ€™m currently away for a few days, but will be back tomorrow. Iโ€™ll take a look at this as soon as I can in the next few days).

Cheers
Chris

On 16 Jun 2015, at 07:29, Uli Fahrer notifications@github.com wrote:

Hi,

as the title says. To get rid of this problem simple remove the following unnecessary code:

scope.$watch('events', function (events) {
angular.forEach(events, function (callback, event) {
if (['select', 'click', 'hoverNode', 'doubleClick'].indexOf(String(event)) >= 0) {
network.on(event, callback);
}
});
});
The problem originates from the change in #33 #33
Best Uli

โ€”
Reply to this email directly or view it on GitHub #35.

Thanks. I don't think this originates from #33 - it's a hangover from an older systen for hooking the events into vis, however you're right, the code is redundant.

Thanks
Chris

Are you happy if this is closed now?

Tooa commented

Sure, we can close the issue.

Thanks.