visualitypl/textris

Using messaging_service_sid with Twilio API integration

Closed this issue · 7 comments

sergmetelin commented

We should be able to use messaging_service_sid instead of :from to send the messages. Is there already a way to do it?

karolsluszniak commented

I think we could accommodate this with new setting that overrides from when used with Twilio delivery. The point is for texters to stay reusable across services that depend on from instead of sid.

philnash commented

I'm happy to take a look into this if you want?

karolsluszniak commented

👍 It would consist of same steps as media_urls, ie. adding new texter/message field which I'd propose to prefix with service name if it's just for Twilio (so twilio_messaging_service_sid or twilio_sid if you think it describes it enough), tests, mail/log delivery and README.

kmanzana commented

Any update on this? We need to use messaging_service_sid's for our app and are going to have to switch back to twilio-ruby if this isn't supported.

philnash commented

Hey @kmanzana, I intended to try and do this, but I have not had the opportunity just yet. I can't promise a particular time that I will be able to get to it either.

You've got a couple of options with this.

  • You can either take a crack at updating the library yourself, it should be relatively similar to adding media_urls as in this pull request, but you'd need to affect number checking in the Textris::Message class
  • You could forget Textris for now and use the twilio-ruby gem directly
  • You could wait for me to finish it up 🙂
kmanzana commented

Thanks for the info @philnash. I'm going to go ahead and take care of it now. I assume you haven't started this yet.

philnash commented

I have not started this yet, so go for it!