voxpupuli/puppet-selinux

Resources that use 'semanage' should have an autorequires on the various packages

Closed this issue · 0 comments

After using the latest release of the module, I noticed that selinux_port was having issues in some of my tests.

This turned out to be that (for whatever reason) the package containing the python semanage library had not yet been installed.

Instead of requiring users to include the entire module, I would like to propose that all commands that need semanage have an autorequires added on the various potential package names.

Unfortunately, this means that a failure in a package update will cascade but this is pretty standard and will fix potential 'dual-run' issues moving forward.

The main drawback is that, as new OS flavors are added, the package list will need to be updated to reflect things. I don't think that requiring the selinux::package class is a good idea because it contains more than the single package that is required for obtaining the semanage command.