Unhandled VulkanError in sync/semaphore.rs causes panic over night

Question

Unhandled VulkanError in sync/semaphore.rs causes panic over night

nicolaiunrein opened this issue 8 months ago · 8 comments

When I leave my application running over night and log out of the PC I encounter the following panic in the morning:

I am using Vulkano v0.33.0 and tracked down this line as the source of the panic:
https://github.com/vulkano-rs/vulkano/blame/096d3bc6605316c62f75ea5ad5908dd03b2efa4f/vulkano/src/sync/semaphore.rs#L1552
I don't know what causes the error but I think it must have something to do with logging out and/or detaching displays.

Answer 1 · 2023-10-03T08:08:57.000Z

The other day after logging in it panicked at https://github.com/vulkano-rs/vulkano/blob/096d3bc6605316c62f75ea5ad5908dd03b2efa4f/vulkano/src/sync/future/fence_signal.rs#L540C43-L540C43 instead.

Answer 2 · 2023-10-03T08:35:16.000Z

The upcoming Vulkano 0.34 release will fix at least the first panic. However, InitializationFailed is an error that is returned by the Vulkan driver itself, and Vulkano doesn't have any way to handle it, other than to pass it on to the user. So the underlying problem lies with your Vulkan driver somewhere.

It's possible that the driver is triggering that error because of something that Vulkano is doing wrong, but that's much harder to determine.

Answer 3 · 2023-10-03T08:45:07.000Z

Thanks for the quick reply.I understand that the problem comes from the driver and cannot be handled by the library but wouldn't it be better to pass the error on to the user in this case instead of panicking?

Answer 4 · 2023-10-03T08:46:39.000Z

In the case of the second panic, it's not possible to pass it on to the user, because it's inside a drop function.

Answer 5 · 2023-10-03T10:24:21.000Z

Let's wait for the v0.34 then and see if it fixes the issue. Thanks again. Feel free to close!

Answer 6 · 2023-10-03T10:29:51.000Z

You can use the current work-in-progress version, by using Vulkano from the Github repository here instead of 0.33 from crates.io. Then you can test it already and see if it still has problems. 0.34 has a bunch of breaking changes that you'll probably need to deal with when you switch, but if you deal with it now, you'll be ready for the release anyway.

Answer 7 · 2023-11-18T13:12:21.000Z

What's the status on this?

Answer 8 · 2023-11-18T14:39:22.000Z

We are still on v0.33.0. But as I said, feel free to close as I think it is resolved as far as I can tell from reading the code. At least what is in the scope of this library