GDFTrace icon resource 101
sredna opened this issue · 1 comments
sredna commented
CGDFParse::OutputGDFIconInfo hardcodes icon id 101 while CGDFParse::IsIconPresent just picks the first icon, which is correct?
For Games Explorer on Windows 8 it seems like the icon id does not matter.
Is there any platform where it matters? What does Vista do if there is no __GDF_THUMBNAIL png resource?
walbourn commented
Game Explorer was deprecated so it's use in the Windows 8 or later UI is minimal, so it's likely why it doesn't matter.
At this point Windows Vista doesn't matter :)
Looking at the code, it takes either the icon named "ID_GDF_THUMBNAIL" -or- it will use the first icon (0th one) in the file, so really either works.