wbotelhos/stepy

_bindFinish fails on Firefox

dleffler opened this issue · 2 comments

dleffler commented

With v1.1.0 under Firefox, if the option finishButton is true, then the _bindFinish method is called... however the var finish won't be assigned to the 'submit' button, line #132

finish = that.children('input[type="submit"]');

finish will be set to null, but a jQuery alternative is

finish = $(':submit',that);

wbotelhos commented

Try to change to .find().
Maybe the button is inside another container and it's not a children.
But, it should be a children, than let me know why it is not.

dleffler commented

Yes every form ‘control’ is inside its own

since this is a programmatically generated form for a cms. I’ll probably just lean toward a locally customized version of stepy, e.g., having a ‘body’ style in the stepy jquery plugin tends to mess with the overall page styling.

Thanks for the good work!

Dave Leffler

From: Washington Botelho [mailto:notifications@github.com]
Sent: Monday, June 03, 2013 10:43 AM
To: wbotelhos/stepy
Cc: dleffler
Subject: Re: [stepy] _bindFinish fails on Firefox (#24)

Try to change to .find().
Maybe the button is inside another container and it's not a children.
But, it should be a children, than let me know why it is not.

—
Reply to this email directly or view it on GitHub #24 (comment) .Image removed by sender.