Ladybug GitHub Actions succeeded even though copyright notices were not OK.

Question

Ladybug GitHub Actions succeeded even though copyright notices were not OK.

mhdirkse opened this issue 8 months ago · 6 comments

Answer 1 · 2024-05-07T11:44:20.000Z

We observed this here:

Answer 2 · 2024-05-07T11:53:19.000Z

@MarkvdVorst suggested that the ladybug backend GitHub test may not test the Maven build of the backend. We know that the ladybug backend tests trigger ladybug-frontend, but that may be the only thing the test does.

Answer 3 · 2024-05-07T12:26:19.000Z

It would be nice to have a dedicated action for backend testing instead of only having a yaml file for ladybug-frontend tests.
I'm guessing the ladybug-frontend yaml also takes the backend into account somehow, but skips the tests copyright and/or unit tests as it did not give me any failed tests earlier when I submitted a PR with wrong copyright year.

Answer 4 · 2024-05-07T12:43:14.000Z

just noticed that PR #227 would fix this

Answer 5 · 2024-05-07T12:50:21.000Z

nevermind. the skip copyright is still present in this

Answer 6 · 2024-07-26T13:18:24.000Z

Ik denk dat de Ladybug backend op Jenkins wordt getest, zie https://jenkins.frankframework.org/job/ladybug-ci/job/ladybug/. Daar wordt de volledige Maven build gedaan, dus zonder opties om stappen over te slaan.