webjay/asapp

Better handling of new requests

Closed this issue · 4 comments

webjay commented

It seems duplicates can still happen. Needs testing.

When:

  • sync: full render
  • model.isNew: prepend
ghtca commented

Looks like the first time I pick a new location or topic, it creates some duplicate. If I stay with the same, it does not. Not 100% true though, sometimes it does not create duplicates… have not been able to fully understand / replicate the bug.

From: Jacob Friis Saxberg [mailto:notifications@github.com]
Sent: Sunday, March 16, 2014 12:45 PM
To: webjay/asapp
Subject: [asapp] Better handling of new requests (#55)

It seems duplicates can still happen. Needs testing.

When:

  • sync: full render
  • model.isNew: prepend

—
Reply to this email directly or view it on GitHub #55 .Description: Image removed by sender.

webjay commented

I think this is a speed issue. Sometimes the client gets away with sending more than one, sometimes not.
If you can live with it, I think coming changes will fix it.

webjay commented

I now see dups every time via my tests, so there's a bug, but I'm sure coming changes will fix it.

ghtca commented

Yep, do it the “right” way, don’t rush any hack. Just let me know when you have a new release. Thanks!

From: Jacob Friis Saxberg [mailto:notifications@github.com]
Sent: Monday, March 17, 2014 12:14 AM
To: webjay/asapp
Cc: ghtca
Subject: Re: [asapp] Better handling of new requests (#55)

I now see dups every time via my tests, so there's a bug, but I'm sure coming changes will fix it.

—
Reply to this email directly or view it on GitHub #55 (comment) .Description: Image removed by sender.