[Enhancement] Lint errors should show line numbers
elyobo opened this issue · 5 comments
elyobo commented
Detailed description
Line numbers should be shown (where possible; if the spec is a single line JSON string then there's not much to be done) in linting errors.
Context
Jumping to the error line would make fixing up errors much easier.
Possible implementation
N/A
Your environment
N/A
pderaaij commented
This should be fixed in #338, @djtarazona can you have a look at the open PRs?
djtarazona commented
This has been added in v0.11.0
elyobo commented
Excellent, thanks!
Anyone care to check out my other PR? ;)
…On Mon, 17 Jun 2019, 12:04 DJ Tarazona, ***@***.***> wrote:
Closed #346 <#346>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#346?email_source=notifications&email_token=AADDR7XTQIRQQQKPFFG6ES3P23WKRA5CNFSM4HUTKK52YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSACO5CQ#event-2416242314>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADDR7RHPE2GWGP7O4QO5WDP23WKRANCNFSM4HUTKK5Q>
.
djtarazona commented
@elyobo Yes, it is a larger PR so I didn't have time to review it this weekend but it's on my list. In the meantime, it has some conflicts if you don't mind resolving those?
elyobo commented
Thanks, I'll be able to look in to the conflicts this evening AU time.
…On Mon, 17 Jun 2019, 12:19 DJ Tarazona, ***@***.***> wrote:
@elyobo <https://github.com/elyobo> Yes, it is a larger PR so I didn't
have time to review it this weekend but it's on my list. In the meantime,
it has some conflicts if you don't mind resolving those?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#346?email_source=notifications&email_token=AADDR7X4HP5YIZPBN7PXV63P23YB3A5CNFSM4HUTKK52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZ3SSI#issuecomment-502511945>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADDR7U7DK2AMXIRWE5O5S3P23YB3ANCNFSM4HUTKK5Q>
.