while-true-do/ansible-skeleton

Feat: Defaults for molecule.yml

dschier-wtd opened this issue · 6 comments

As a developer, I want to run 'molecule test' without defining variables. Defaulting to something like fedora or centos would be sufficient.

starting to work on this in fb-daniel-wtd

An update to the existing roles is needed.

I will prepare a mass-push and release the roles during the next 2 days. since ansible 2.8 breaks everything anyway, It should hurt ^^

goal: all roles are running with some paramters, tests are reviewed, become is used, container do not run privileged, known issues is updated.

Fix: #62, #60, #64, #61 and #67

todo

all steps below must be performed for all (new) roles.

testing

  • check molecule/default/molecule.yml
  • check molecule/default/Dockerfile.j2
  • check molecule/default/playbook.yml to properly test the role with some parameters
  • check if skippings for docker are needed in tasks/handlers
  • check if skippings for tests are needed in molecule/defaults/tests/*

role

  • check meta/main.yml for proper format
  • remove pycache if still present in some roles
  • check travis.yml for proper format
  • check variable naming in defaults/main.yml
  • check task naming in tasks/main.yml
  • check if firewall is configured in tasks/main.yml
  • check if selinux is configured in tasks/main,yml
  • check if role fails properly, when deps are missing
  • check if docs are updated to reflect this behaviour
  • check if all tasks and handlers are having proper tags

This all together will be the next minor release for each role.

updated:

  • app_ansible
  • app_bash

all roles done.