wicketstuff/core

[Dashboard] Missing jquery-json dependency

ZwoCa opened this issue · 6 comments

ZwoCa commented

Hi,

I just noticed a problem regarding the dashboards when I updated Wicket alongside Wicketstuff from 8.14.0 to 9.12.0:

It seems like the dashboard script still wants to use jquery-json:


However, since commit 862d958, jquery-json is not included anymore. This triggers a Javascript error and the serialization will fail.

I see that in DashboardSettings the fields and methods regarding jquery-json are deprecated.

However, considering that the dashboard.js still needs jquery-json, it's not clear to me if this changes were intended. Is the user expected to include jquery-json his own? If so, I think this should be documented in README.me "How to use" section.

Regards
-- Sebastian

I'll take look

Should be fixed :)
Do you need new SNAPSHOT?

Thanks for the report :)

ZwoCa commented

Thanks for the super-fast fix. :)

I don't need a SNAPSHOT, for now I've added my own behavior including the jquery-json as a workaround.

I can create point release :)
Or it will be released with next version of wicket :)

ZwoCa commented

Thanks, personally I can wait for the next wicket version, until then using json-query is sufficient for me. But of cause if you create a point release, I'm going to use it.

9.12.0 was released in October, I believe next release will happen soon :)
Let's wait :)