wilsonvargas/ScreenshotPlugin

CaptureAndSaveAsync doesn't always return the path

Opened this issue · 0 comments

Hi,

Thank you for the plugin first of all.

The line below appears problematic to me as it will return an exception message instead of a file path and the caller won't even be aware of that.

I would suggest not catching at all or rethrowing or even returning null to prevent a breaking change and keeping things simple.

Otherwise a new data structure could be used as well, such as a class that contains the path to the image and a status that tells if the capture was successful or not. But that would be a breaking change.

The same problem is present on iOS too:

result = nsError.LocalizedDescription;

I am willing to contribute for a fix.

Thanks.