Visual Studio 1017 - No Local Eslint Found

[jpx2001]

Installed product versions

• Visual Studio: 2017 Enterprise Version 15.9.12
• This extension: [1.1.104]

Description

VisualLinter prints "exception: no local eslint found"

However, ESLint shows warnings and bugs in the Error window. I don't know if the Output window text is wrong or if this is a real problem.

Steps to recreate

1. Build or rebuild an ASPNet MVC project that has javascript files.
2. Open the Output Window
3. Show output from: VisualLinter
4. VisualLinter prints "exception: no local eslint found"

Current behavior

VisualLinter prints "exception: no local eslint found"

Expected behavior

Should not display the above message. Because VisualLinter has always done this, I don't know what, if anything, VisualLinter should print to the Output window. It needs to work properly for me to know what to expect.

[woldner]

Hey @jpx2001!
Are you sure that you've installed eslint locally (e.g. exists in your package.json) and it is VisualLinter that are reporting the errors in the error list?
You see, Visual Studio 2017, and newer, has built in ESLint support. The difference between VisualLinter and the built in functionality is that VisualLinter will always use the ESLint version you've installed in your project, while the built in is using a bundled (and often very old) version of ESLint.

See the Troubleshooting section of the readme, on how to disable the built in features and ensure it is VisualLinter that reports the errors.

[jpx2001]

Jean, Thank you so much for your quick response. I have eslint installed globally and a package.config file in the root of my repository source folder. · Do I need to install eslint locally to each web project? · Can I install locally to the solution folder? Thanks From: Jean Alexander Woldner <notifications@github.com> Sent: Tuesday, July 16, 2019 8:20 AM To: jwldnr/VisualLinter <VisualLinter@noreply.github.com> Cc: Jeffery Pyle <Jeffery.Pyle@traviscountytx.gov>; Mention <mention@noreply.github.com> Subject: [CAUTION EXTERNAL] Re: [jwldnr/VisualLinter] Visual Studio 1017 - No Local Eslint Found (#59) CAUTION: This email is from OUTSIDE Travis County. Links or attachments may be dangerous. Click the Phish Alert button above if you think this email is malicious.

…

________________________________ Hey @jpx2001<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jpx2001&d=DwMCaQ&c=TjtWVPF8cdYj1jaCmcOWCvhA7Dw-i54lFAEiof1ZnAU&r=t3pWXhu-5-RpjUiGIIx_W1Cul_twAszL89LrHkT5vTU&m=nwXOF8Y_5qN8i_d4Fxyephlz0hzT0oRUeMSvE3uIug4&s=5m2CceZORb8d32JaKP7OyX0iY9gyy8vazHVQGaUGnIc&e=>! Are you sure that you've installed eslint locally (e.g. exists in your package.json) and it is VisualLinter that are reporting the errors in the error list? You see, Visual Studio 2017, and newer, has built in ESLint support. The difference between VisualLinter and the built in functionality is that VisualLinter will always use the ESLint version you've installed in your project, while the built in is using a bundled (and often very old) version of ESLint. See the Troubleshooting<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jwldnr_VisualLinter-23known-2Dissues&d=DwMCaQ&c=TjtWVPF8cdYj1jaCmcOWCvhA7Dw-i54lFAEiof1ZnAU&r=t3pWXhu-5-RpjUiGIIx_W1Cul_twAszL89LrHkT5vTU&m=nwXOF8Y_5qN8i_d4Fxyephlz0hzT0oRUeMSvE3uIug4&s=ktHpJB8td_mc6AY80W0XI0koeljvuaSkpmky1cKfidw&e=> section of the readme, on how to disable the built in features and ensure it is VisualLinter that reports the errors. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jwldnr_VisualLinter_issues_59-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAMUCQ7DJCXDOEQHSPFPYA23P7XDITA5CNFSM4IEAUAR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2A2HHY-23issuecomment-2D511812511&d=DwMCaQ&c=TjtWVPF8cdYj1jaCmcOWCvhA7Dw-i54lFAEiof1ZnAU&r=t3pWXhu-5-RpjUiGIIx_W1Cul_twAszL89LrHkT5vTU&m=nwXOF8Y_5qN8i_d4Fxyephlz0hzT0oRUeMSvE3uIug4&s=MVl0U7PAbVJLQa-K8whTHftZNEYqNpcs--yypzSxINo&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMUCQ7ACDZQRUDVDZTUV3W3P7XDITANCNFSM4IEAUARQ&d=DwMCaQ&c=TjtWVPF8cdYj1jaCmcOWCvhA7Dw-i54lFAEiof1ZnAU&r=t3pWXhu-5-RpjUiGIIx_W1Cul_twAszL89LrHkT5vTU&m=nwXOF8Y_5qN8i_d4Fxyephlz0hzT0oRUeMSvE3uIug4&s=i_5lCOHYAHvZsmeaM5oYfDTCpvC7gNqfCBqquBIn-nw&e=>.

________________________________ This electronic mail message, including any attachments, may be confidential or privileged under applicable law. This email is intended solely for the use of the individual or entity to which it is addressed. If you are not the intended recipient of this email, you are notified that any use, dissemination, distribution, copying, disclosure or any other action taken in relation to the content of this email including any attachments is strictly prohibited. If you have received this email in error, please notify the sender immediately and permanently delete the original and any copy of this email, including secure destruction of any printouts.

[woldner]

No problem!
The default behavior is set to use a local installation of ESLint (per project).

If you wish to use a global ESLint installation, you will need to enable this option in Visual Studio under Tools > Options > VisualLinter.

See the notes section of the readme on how to configure global installation and/or config settings. 😸

[pmcelhaney]

I'm on Visual Studio 2019 (16.1.3) and getting the same error.

I have ESlint installed locally. Running ./bin/eslint . works fine. The built-in version is also running the locally installed ESLint.

[woldner]

Could you share the full path to the file you're trying to lint and also the full path to where eslint is installed (in node_modules)

Thanks

[pmcelhaney]

It’s something like z:\code\project\file.js

ESLint and the plugin are installed at z:\code\project\package.json

The problem is ESLint looks for plugins relative to the current working directory, which is the user directory when run from Visual Studio. When I remove all plugins from the config, it works just fine.

[Indigo744]

Same issue on VS 2019.

VisualLinter configured to use local install (and analyze only ts/tsx files).
ESLint is installed in the project.
Running eslint manually works fine.

[Indigo744]

After playing a little with it, I found out that it was because Visual Studio actually butchered the local packages.

What I did to fix the issue:

• First, deactivate automatic npm restore by VS
  
• Delete node_modules folder
• run npm install

And it works.

[woldner]

Sorry everyone; but the development of this extension has been suspended.
You can read more about it here:
https://github.com/jwldnr/VisualLinter#deprecated