wtsi-hgi/aeg-scrambler

Decompose function

Opened this issue · 0 comments

KMace commented

def export_convolutions(self, configuration):

This goes against the grain of what a function should be - a short, simple piece of code that does one select thing.

I would rewrite this so that you have a function, export_convolutions(), which iterates through self.data, but in doing so calls two other functions. Each of the two functions would be responsible for writing the different parts of what needs to be written.
Separation of concerns!