wtsi-hgi/hgi-systems

`ansible-consul : consul config file` task is not idempotent

Closed this issue · 4 comments

colin-nolan commented

Task path: /data/hgi-systems/subrepos/ansible-consul/tasks/install.yml:192

colin-nolan commented

Running a diff on the files before and after a change shows changes in the order of the "retry_join" values.

Before:

    "retry_join": [
        "192.168.102.51",
        "192.168.102.47"
    ],

After:

    "retry_join": [
        "192.168.102.47",
        "192.168.102.51"
    ],
colin-nolan commented

Needs a | sort here:

hgi-systems/subrepos/ansible-consul/templates/consul.json.j2

Line 21 in 9c56d7f

"retry_join_wan": [{% for host in consul_servers_wan | difference(ansible_all_ipv4_addresses) %}"{{host}}"{% if not loop.last %}, {% endif %}{% endfor %}],

colin-nolan commented

Pull request with fix pending: mattfinlayson/ansible-consul#198. Switched to using our fork to get the fix without waiting for the merge upstream.