Permissions are ignored for COPY commands

Question

Permissions are ignored for COPY commands

Closed this issue 6 years ago · 4 comments

jrandall commented 6 years ago

The permissions of the source being COPY'd do not seem to factor in to the hash calculation.

Answer 1 · 2019-01-26T19:17:53.000Z

True: https://github.com/wtsi-hgi/thrifty-builder/blob/master/thriftybuilder/checksums.py#L54-L56.

Answer 2 · 2019-01-26T19:42:58.000Z

Fixed by 050569c.

The downside to this change is that it will generate new checksums for everything, leading to rebuilds across the board. I considered only throwing the permission into the hasher if it was not "normal" (possibly saving on the rebuilds) but I don't think the addition of odd complexity would be worth it.

Answer 3 · 2019-01-26T20:13:36.000Z

Full fix (that considers changes to directory permissions) is blocked on #10.

Answer 4 · 2019-02-01T09:59:42.000Z

Pending merge to master