xavirn/glmatrix

mat4.lookat bug

Closed this issue · 2 comments

In mat4.lookat(...),  "return mat4.identity()" should be "return 
mat4.identity(dest)".

In general I think that there you need to make a clearer separation of 
destructive vs non destructive operations eg

function mat4.setIdentity(dest) { ..... return undefined;}

 and 

function mat4.identity() {var dest=mat4.create(); mat4.setIdentity(dest); 
return dest; } 

Also I notice there isn't a quat4.create() method at the moment.

And +1 for unit testing :-)

Original issue reported on code.google.com by Drew.Whitehouse on 24 Jun 2010 at 1:59

Original comment by Tojiro@gmail.com on 2 Jul 2010 at 4:44

  • Changed state: Started

Original comment by Tojiro@gmail.com on 27 Feb 2011 at 6:18

  • Changed state: Fixed