xbmc/repo-scripts

[Update] service.subtitles.wizdom

wizupdate opened this issue · 14 comments

wizupdate commented

Add-on details:

Description of changes:

Source URL change from the initial release of this add-on.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
Rechi commented

Please submit a Pull Request.

wizupdate commented

Even if the add-on is already in the repo?

Rechi commented

Yes.

enen92 commented

Closing as it looks stalled. Please let us know if you need us to PR on your behalf and we'll reopen the issue

wizupdate commented

Hi
Can you please help with the PR?

wizupdate commented
wizupdate commented

Hey
Can you please PR on our behalf?

enen92 commented

Yes will do it today.

enen92 commented

@wizupdate is the tag still correct? It looks like the last version is already 2.0.2: https://github.com/wizupdate/service.subtitles.wizdom/releases

wizupdate commented

Thank you for your help.
The latest release is indeed 2.0.2.

enen92 commented

PR was made: #1263

I'll review the code and likely request a few changes. I'll pick them from your repo (upstream location of the code)

enen92 commented

@wizupdate see comments in the pull request. Please move the discussion there.

wizupdate commented

@enen92 Thank you very much for your help.

basrieter commented

Continued here: #1263