Consolidate duplicate tc-loader scripts

Question

Consolidate duplicate tc-loader scripts

tohojo opened this issue 4 years ago · 5 comments

We should probably consolidate the different copies of the TC loader scripts in subdirectories into a single version in a parent/lib directory...

Answer 1 · 2021-02-08T10:18:08.000Z

Same thing probably goes for the configure script to detect if iproute has libbpf support.

Answer 2 · 2021-02-08T14:41:01.000Z

Yeah. IIRC, @netoptimizer expressed a preference for keeping separate configure scripts in each subdir, but they can still share code :)

Answer 3 · 2021-03-15T09:27:56.000Z

Worth mentioning that in my current PR I've extended the tc loader script somewhat to support attaching a pinned program (and gotten rid of the configure script).

Answer 4 · 2021-06-03T09:45:12.000Z

As libbpf now support TC-attaching directly, we should consider converting "pping" and "traffic-pacing-edt" to use that instead of mentioned shell script.

Answer 5 · 2021-06-03T10:53:57.000Z

Yep, converting pping to use libbpf for attaching the tc program is on my TODO list, so this issue is likely goning to resolve itself that way.