xiongchiamiov/git-suggest-reviewers

Don't suggest ex-employees.

Opened this issue · 1 comments

This is awesome, but the one thing that stands out to me as potentially confusing (esp. for new employees) is that it may suggest former employees as reviewers. For example, Max Goodman is shown as the top suggestion for two of the sample cases, but he no longer works here.

Yeah. It's problematic in that there's no terribly generic way of dealing with that. Two options come to mind:

  1. Gather list of people from a specified/configured Github organization, and either use that instead, or filter using it.
  2. Rather than grabbing the most recent 100 commits, grab everything since a certain date.

Or perhaps do something much more reddit-specific, but that'll probably be more private-code-y.