xp-framework/xp-runners

Warnings with HHVM

Closed this issue · 1 comments

Warning: No such file or directory in /home/vagrant/bin/class-main.php on line 140
Warning: Invalid argument supplied for foreach() in /home/vagrant/bin/class-main.php on line 160

This stems from the situation that opendir() return false in PHP when given an empty string, but doesn't on HHVM.

A simple fix in line 137 could be to ignore empty paths:

if ('' === $path || !($d= @opendir($path))) continue;

This happens with 5.2.0-RELEASE, in current master, we also get problems with PHP:

Error, Uninitialized string offset: 0 @ C:\...\shared\src\scan-path.php:15