BPM loaded incorrectly - e.g. 1.2815E+16

Question

BPM loaded incorrectly - e.g. 1.2815E+16

Closed this issue 6 years ago · 4 comments

FelixFifi commented 6 years ago

Version:
Beat Saber v0.11.1
Song Loader 4.2

How to reproduce:

Download Waiting for love - Avicii
Play the song
All notes skip you or run into you at the very beginning

Possible cause:
BPM is set to a float
"_beatsPerMinute":128.14999389648438,

Answer 1 · 2018-07-20T23:15:26.000Z

The value seems to be off by the factor 10^14 while the digits are the same as in the json file.

Answer 2 · 2018-07-20T23:19:54.000Z

This has been fixed with this commit 7af0d1f

The problem was I wasn't stating a specific culture when converting the text to number, so for some system languages a decimal is separated with commas instead of periods.

I'll close this issue when the release is out.

Answer 3 · 2018-07-20T23:31:51.000Z

This is been fixed with this release:
https://github.com/xyonico/BeatSaberSongLoader/releases/tag/v4.2.2

Answer 4 · 2018-07-20T23:33:09.000Z

Thank you 👍
I know that problem from my .NET projects :/

PS: Sorry for the duplicate issue 🙈