bunyan dependency on dtrace-provider is problematic
Qard opened this issue · 3 comments
Qard commented
Apparently bunyan has an optional dependency on dtrace-provider
. While optional dependencies are generally okay, it's problematic in this case because dtrace-provider
is a native module and therefore requires Python to be installed on the system to even attempt the install. This is especially problematic on Windows because it does not include Python by default therefore measured fails to install. Perhaps we should switch to another logger, like pino?
It has caused no end of issues opened on the bunyan repo... https://github.com/trentm/node-bunyan/issues?q=is%3Aissue+dtrace
fieldju commented
I am ok with switching to pino. I think I mainly use Winston and pass it in
as an option anyway.
Are you going to make a PR?
Cheers,
Justin
On Tue, Feb 26, 2019 at 2:06 PM Stephen Belanger ***@***.***> wrote:
Apparently bunyan has an optional dependency on dtrace-provider. While
optional dependencies are generally okay, it's problematic in this case
because dtrace-provider is a native module and therefore requires Python
to be installed on the system to even *attempt* the install. This is
especially problematic on Windows because it does not include Python by
default therefore measured fails to install. Perhaps we should switch to
another logger, like pino <https://www.npmjs.com/package/pino>?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#60>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArcLg7CO0NF3hxEs39VS-NlXBzjJRHbks5vRYXDgaJpZM4bS5MS>
.
--
Justin Field
fieldju@gmail.com
LinkedIn <https://www.linkedin.com/in/fieldju> | @fieldju
Qard commented
Yep, I can do that, when I get some time. I just wanted your thoughts before diving into it. 👍
fieldju commented
Merged PR fixes this.