yaorg/node-measured

bunyan dependency on dtrace-provider is problematic

Qard opened this issue · 3 comments

Qard commented

Apparently bunyan has an optional dependency on dtrace-provider. While optional dependencies are generally okay, it's problematic in this case because dtrace-provider is a native module and therefore requires Python to be installed on the system to even attempt the install. This is especially problematic on Windows because it does not include Python by default therefore measured fails to install. Perhaps we should switch to another logger, like pino?

It has caused no end of issues opened on the bunyan repo... https://github.com/trentm/node-bunyan/issues?q=is%3Aissue+dtrace

Qard commented

Yep, I can do that, when I get some time. I just wanted your thoughts before diving into it. 👍

Merged PR fixes this.