yegor256/cactoos-http

BlockingSocketServer.java:45-52: Rework the...

Closed this issue · 14 comments

0pdd commented

The puzzle 87-b84e58fc from #87 has to be resolved:

* @todo #87:30min Rework the implementation of this class not
* to rely on the `backlog` behaviour of `ServerSocket` because
* the assumption made on it can be wrong on some contexts as
* explained in the `ServerSocket` javadoc and as experienced
* in https://github.com/yegor256/cactoos-http/pull/93 when
* the tests are executed by rultor. See this same PR for more details.
* Unignore the tests in `BlockingSocketServerTest` and `HtTimedWireTest`
* after.

The puzzle was created by @rultor on 21-Oct-19.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0crat commented

@paulodamaso/z please, pay attention to this issue

0crat commented

Job #98 is now in scope, role is DEV

0crat commented

The job #98 assigned to @iakunin/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel @paulodamaso I cannot reproduce the problem with rultor-build (https://www.rultor.com/t/20323-537729119) locally.

I unignored the tests and run the same command in the same docker-image

docker run --tty --interactive --workdir=/main --volume=${PWD}:/main --rm yegor256/java8 "mvn clean install -Pqulice --errors"

and this build successfully passed. The full build log is here.

Maybe we can try to unignore the ignored tests and try to build rultor one more time?

@0crat wait for #98 (comment) to be answered.

0crat commented

@0crat wait for #98 (comment) to be a... (here)

@iakunin The impediment for #98 was registered successfully by @iakunin/z

@0crat wait for #101 to be merged

0crat commented

@0crat wait for #101 to be merged (here)

@iakunin Job #98 is already on hold

0pdd commented

The puzzle 87-b84e58fc has disappeared from the source code, that's why I closed this issue.

0crat commented

The job #98 is now out of scope

0crat commented

@sereshqua/z please review this job completed by @iakunin/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat quality good

0crat commented

Quality review completed: +4 point(s) just awarded to @sereshqua/z

0crat commented

Order was finished, quality is "good": +35 point(s) just awarded to @iakunin/z