ymirapp/cli

`import:uploads` sftp doesn't support ed25519 keys

Closed this issue · 1 comments

When using sftp import:uploads parses a url, sends it to League\Flysystem\PhpseclibV2\SftpConnectionProvider

PhpseclibV2 doesn't support ed25519 keys. The logic in SftpConnectionProvider is to use an agent unless opt'd out (7th parameter of SftpConnectionProvider).

I suggest two workarounds:

1.) if password is specified set useAgent = false.

2.) add an additional cli argument to disable agent.

PhpseclibV3 support is also available. I haven't looked into it (unsure about backwards compat).

thephpleague/flysystem#1261

I'll open a PR for workaround 1 as it seems sane to me. Of course both of these only handle the case where password access is available!

I'll bump the version of phpseclib when I can. They haven't released a new version with v3 support yet. I'll open another issue for it.