yuki-koyama/elasty

Implicitly Requiring OpenEXR v2.3.0 (or above)

yuki-koyama opened this issue · 3 comments

OpenEXR v2.3.0 supports C++17 compilation, but older versions do not.
https://github.com/openexr/openexr/releases/tag/v2.3.0

As the elasty library is written in C++17 (although not intensively used the new features in C++17 currently), it implicitly requires OpenEXR v2.3.0 (or above). This requirement needs to be explicitly written in README.md and also adequately handled in CMakeLists.txt.

Related to this, the following line in CMakeLists.txt is no longer necessary assuming OpenEXR v2.3.0:

set_target_properties(Alembic PROPERTIES CXX_STANDARD 11)

Note: just adding brew update before brew install openexr could install OpenEXR v2.3.0 (rather than v2.2.0) and so fixed the build error in Travis CI.

Related issue: #16