zalando/logbook

Add filters to JsonPathBodyFilterBuilder jsonPath

bata19 opened this issue · 12 comments

Add filters to:

public static JsonPathBodyFilterBuilder jsonPath(final String jsonPath) {
        return new JsonPathBodyFilterBuilder(compile(jsonPath));
    }
public static JsonPathBodyFilterBuilder jsonPath(final String jsonPath, Predicate... filters) {
        return new JsonPathBodyFilterBuilder(compile(jsonPath, filters));
    }

For example, we can select only leaf element:

jsonPath("$..pets[?]", new Predicate() {
    @Override
    public boolean apply(PredicateContext ctx) {
        Object val = ctx.item();
        return !(val instanceof Map || val instanceof List);
    }
});

Happy to contribute

@bata19 if you have a plan in mind how to make the necessary changes, please feel free to open a PR. This is more than welcome.

Anyone working on this one?

Anyone working on this one?

@kasmarian

@pedroluiznogueira If @bata19 is not looking into this, then I'd not expect any progress at the moment. I haven't seen PRs yet

@kasmarian may I work on this then?

@pedroluiznogueira Feel free to do it if you have any bandwidth. I could only do it some time at a later point.

Will do! I've got some time to take a look into that.

In order to prioritize the support for Logbook, we would like to check whether the old issues are still relevant.
This issue has not been updated for over six months.

  • Please check if it is still relevant in latest version of the Logbook.
  • If so, please add a descriptive comment to keep the issue open.
  • Otherwise, the issue will automatically be closed after a week.

This issue has automatically been closed due to no activities. If the issue still exists in the latest version of the Logbook, please feel free to re-open it.

@kasmarian @whiskeysierra I was searching for a way to contribute to this project and I remembered this issue, is this still worth doing? I took a look and it seems like it's still not supported.

@pedroluiznogueira if you find a need for this feature, feel free to reopen this issue and add a PR with your proposal. There was no interest in the issue in the last several months, so the bot closed it.