zalando/logbook

logbook-spring-boot-autoconfigure in 3.0.0-RC.2 is still using javax namespace dependencies

marcindabrowski opened this issue · 3 comments

Logbook in version 3.0.0 was supposed not to use javax dependencies.

Description

In logbook-spring-boot-autoconfigure pom.xml there are two entries with javax artifacts.

<dependency>
  <groupId>org.zalando</groupId>
  <artifactId>logbook-servlet</artifactId>
  <version>${project.version}</version>
  <classifier>javax</classifier>
  <optional>true</optional>
</dependency>

<dependency>
  <groupId>javax.servlet</groupId>
  <artifactId>javax.servlet-api</artifactId>
  <version>4.0.1</version>
  <scope>compile</scope>
</dependency>

Expected Behavior

Artifacts with jakarta namespace should be used.

Actual Behavior

Artifacts with javax namespace are used.

Your Environment

  • Version used: 3.0.0-RC.2

Same problem here.

The artifact "org.zalando:logbook-spring-boot-autoconfigure:3.0.0-RC.2" still depends on "javax.servlet".

Hi, the logbook-servlet dependency is set to optional. That means it won't be pulled if not explicitly needed. I set the servlet-api dep to optional as well now: #1498. That should do the trick. Thanks for the hint!

Thanks for the fix. After migration to 3.0.0 final javax namespace is not imported anymore.