zalgonoise/eljoth-go-code-review

Issues

• testing: improve tests (unit tests, e2e tests)

  #27 opened 2 years ago by zalgonoise
  0

• docs: Missing documentation in Go code

  #26 opened 2 years ago by zalgonoise
  0

• docker: builder pattern is incomplete

  #3 opened 2 years ago by zalgonoise
  0

• runtime logic: review and cleanup

  #49 opened 2 years ago by zalgonoise
  0

• cmd/coupon_service: Main file improvements

  #28 opened 2 years ago by zalgonoise
  0

• entities: HTTP objects should not be declared as entities

  #6 opened 2 years ago by zalgonoise
  1

• internal/config: Config improvements

  #17 opened 2 years ago by zalgonoise
  0

• internal/api: Get endpoint improvements

  #25 opened 2 years ago by zalgonoise
  0

• internal/api: Create endpoint improvements

  #24 opened 2 years ago by zalgonoise
  0

• internal/api: Apply endpoint improvements

  #23 opened 2 years ago by zalgonoise
  0

• internal/api: Close method improvements

  #22 opened 2 years ago by zalgonoise
  0

• internal/api: Start method improvements

  #21 opened 2 years ago by zalgonoise
  0

• internal/api: New function improvements

  #20 opened 2 years ago by zalgonoise
  0

• internal/api: API type improvements

  #19 opened 2 years ago by zalgonoise
  0

• internal/service: GetCoupons method improvements

  #16 opened 2 years ago by zalgonoise
  0

• internal/service: CreateCoupon method improvements

  #15 opened 2 years ago by zalgonoise
  0

• internal/service: ApplyCoupon method improvements

  #14 opened 2 years ago by zalgonoise
  0

• internal/api: Service interface

  #18 opened 2 years ago by zalgonoise
  0

• internal/repo/memdb: Save method does not validate input

  #12 opened 2 years ago by zalgonoise
  0

• internal/repo/memdb: FindByCode method improvements

  #10 opened 2 years ago by zalgonoise
  0

• internal/repo/memdb: Repository implementation is not concurrency-safe

  #9 opened 2 years ago by zalgonoise
  0

• internal/repo/memdb: New function is not initializing the Repository's map element

  #11 opened 2 years ago by zalgonoise
  1

• internal/repo/memdb: repository interface is declared within the implementation

  #8 opened 2 years ago by zalgonoise
  0

• internal/service: Repository is redeclared in this package

  #13 opened 2 years ago by zalgonoise
  0

• internal/repo/memdb: Config struct is empty

  #7 opened 2 years ago by zalgonoise
  0

• entities: init sequence (32 CPU requirement) is unclear

  #5 opened 2 years ago by zalgonoise
  0

• entities: separate declarations and repeated declarations

  #4 opened 2 years ago by zalgonoise
  0

• go.mod: module should point to a URL

  #2 opened 2 years ago by zalgonoise
  0