zhanglab/psamm

Rename --reaction options to --objective

jonls opened this issue · 3 comments

jonls commented

For fba, robustness, fva and similar commands there is an option called --reaction to select a different reaction to optimize than the biomass reaction specified in model.yaml. The name of this option is not very descriptive. --objective seems to be a better choice.

Other options: --maximize, --optimize, --biomass...

jonls commented

@keitht547 thoughts?

I like --objective or --optimize.

On 9/10/15 5:40 PM, Jon Lund Steffensen wrote:

For |fba|, |robustness|, |fva| and similar commands there is an option
called |--reaction| to select a different reaction to optimize than
the biomass reaction specified in |model.yaml|. The name of this
option is not very descriptive. |--objective| seems to be a better choice.

Other options: |--maximize|, |--optimize|, |--biomass|...


Reply to this email directly or view it on GitHub
#30.

*** New email address: yingzhang@uri.edu ***

Ying Zhang
Assistant Professor
Department of Cell and Molecular Biology
College of the Environment and Life Sciences
University of Rhode Island

I like --objective too. I think it makes it pretty clear what it is. especially with robustness where there can be two user defined reactions in the input

On 10 Sep 2015, at 19:10, yingzhanguri notifications@github.com wrote:

I like --objective or --optimize.

On 9/10/15 5:40 PM, Jon Lund Steffensen wrote:

For |fba|, |robustness|, |fva| and similar commands there is an option
called |--reaction| to select a different reaction to optimize than
the biomass reaction specified in |model.yaml|. The name of this
option is not very descriptive. |--objective| seems to be a better choice.

Other options: |--maximize|, |--optimize|, |--biomass|...


Reply to this email directly or view it on GitHub
#30.

*** New email address: yingzhang@uri.edu ***

Ying Zhang
Assistant Professor
Department of Cell and Molecular Biology
College of the Environment and Life Sciences
University of Rhode Island


Reply to this email directly or view it on GitHub #30 (comment).