zimolzak/fcc-rf-formulas

Issues

• Are docstring lines too long?

  #23 opened 2 years ago by zimolzak
  0

• Order of params and {gf float versus boolean} should be consistent.

  #21 opened 4 years ago by zimolzak
  0

• Maybe make 'expected' a dict and then can use __dict__ from the class & not this _list thing.

  #22 opened 4 years ago by zimolzak
  0

• __repr__ for various classes

  #18 opened 4 years ago by zimolzak
  0

• I decided I like type hints. Be consistent.

  #19 opened 4 years ago by zimolzak
  0

• A class for every unit?

  #20 opened 4 years ago by zimolzak
  0

• These 4 params are the next candidate for Class because

  #17 opened 4 years ago by zimolzak
  1

• Consider a Class instead of dict.

  #16 opened 4 years ago by zimolzak
  1

• Needs better docstrings

  #15 opened 4 years ago by zimolzak
  1

• Put all stupid distance conversions in global constants

  #12 opened 4 years ago by zimolzak
  0

• Make sure not mixing feedpoint power and ERP

  #14 opened 4 years ago by zimolzak
  0

• More logical ordering of funcs in fcc.py and test_fcc.py

  #13 opened 4 years ago by zimolzak
  0

• Should I make subclass of ValueError for 2 diff errors (freq & dist)?

  #6 opened 4 years ago by zimolzak
  1

• One top-level function

  #10 opened 4 years ago by zimolzak
  1

• Make more user-friendly ValueError strings.

  #11 opened 4 years ago by zimolzak
  0

• Consider shunting from pth() to erpth() if freq out of range

  #1 opened 4 years ago by zimolzak
  1

• Maybe catch negative (cm < 0) because it returns imaginary power.

  #7 opened 4 years ago by zimolzak
  0

• What happens if pytest -v --cov ?

  #8 opened 4 years ago by zimolzak
  0

• Would list of lambda() make these shorter?

  #9 opened 4 years ago by zimolzak
  1

• Consider new function & arg names; currently not very intuitive

  #4 opened 4 years ago by zimolzak
  0

• Check against expected vals, pyunit or pytest or at least assert()

  #5 opened 4 years ago by zimolzak
  0

• Not supposed to raise generic Exception. Do more specific like ValueError or something.

  #2 opened 4 years ago by zimolzak
  0

• These f1() etc are ugly in help(fcc) and not user facing.

  #3 opened 4 years ago by zimolzak
  0