zladx/LADX-Disassembly

Identify the remaining sound effects constants

kemenaran opened this issue · 3 comments

kemenaran commented

Many places in the code still have sound effects (sfx, or music tracks) referenced by a numeric value. For instance:

  ld a, $35
  ld [hNextMusicTrack], a

We should ensure that everywhere in the code, these numeric values are replaced by proper constants (found in constants/sfx.asm). For instance:

  ld a, MUSIC_MAMUS_SONG
  ld [hNextMusicTrack], a
Vextrove commented

I have already done this. I am trying to figure out how to upload an entire src/ folder to github.

Vextrove commented

Oh. I only did it for music files. I have identified all but one music track.
I want to make sure no sound effects are mislabeled like the music used to be. Although some sound effects - particularly those from noiseSFX - are really generic and could be used for two or more entirely different things.

kemenaran commented

@Vextrove did a lot of these constants.

Now only remains a handful of unidentified constants in src/constants/sfx.asm. Updating the issue title to reflect this.