zladx/LADX-Disassembly

Rename `Velocity` to `Speed`

kemenaran opened this issue · 5 comments

Most speed-related variables are named Speed-Something – but some still use the outdated Velocity name.

We should rename variables and comments so that “speed” is used everywhere.

daid commented

I disagree.

I would say "velocity" is something actual, like, if you are walking to the right, link's velocity is 1 pixel per frame. But "speed" is something constant/config, even if you are standing still, link's speed while walking right is 1 pixel per frame. (atleast, that is how I always use velocity vs speed)

Hmm, interesting. Like speed is a fixed attribute of an entity (how fast can it move?), and velocity is “how fast does it moves right now”?

In that case making the variables consistent probably means renaming them to Velocity rather than Speed.

daid commented

Hmm, interesting. Like speed is a fixed attribute of an entity (how fast can it move?), and velocity is “how fast does it moves right now”?

Yes, that's how I usually use it. But other people will most likely disagree, we are on the internet after all :D

Can I Get This Issue?

daid commented

You can do what you want, we dont work as a strict organization here.