Label palettes data

Question

kemenaran opened this issue 3 years ago · 4 comments

There's a lot of raw palette data in src/code/palettes.asm. They are properly split up, but should be labeled according to their actual usage.

Answer 1 · 2023-03-29T13:24:16.000Z

This has mostly been fixed by the numerous PRs of @KelseyHigham.

Does this issue still needs to remain opened?

Answer 2 · 2023-03-29T14:42:15.000Z

I've labeled all the palettes I'm aware of. Though there might be a bit more low-hanging fruit if I search the disassembly for "palette"...?

Answer 3 · 2023-03-29T14:44:40.000Z

I'm comfortable with it being closed, I can make a new issue if I look into doing that.

Answer 4 · 2023-03-29T15:27:19.000Z

Ok! I guess it's better to keep issues immediately actionable, so let's close this one 👍