Prefix in DMARC module differs from RFC

[bayerhonza]

Hello,

while using the DMARC module, we found that its implementation modules/dmarc/dmarc.go#L56 checks only the first 7 characters ("v=DMARC") of DMARC TXT record and not the ABNF defined in RFC 7489 as "v=DMARC1" with optional whitespaces.

This can lead to cases when a DMARC of a domain is not set up correctly (e.g. "v=DMARCv1") and zdns' result status is "NOERROR" even though the DMARC configuration is not valid.

Is it an intentional behviour?

Thanks.

[zakird]

This sounds like a bug. Would you be willing to submit a pull request to fix?

…

On Tue, Sep 28, 2021 at 4:51 AM Jan Bayer ***@***.***> wrote: Hello, while using the DMARC module, we found that its implementation modules/dmarc/dmarc.go#L56 <https://github.com/zmap/zdns/blob/ed5b6828b56753f42903a3b7b82ade161e65ec02/modules/dmarc/dmarc.go#L56> checks only the first 7 characters ("v=DMARC") of DMARC TXT record and not the ABNF defined in RFC 7489 <https://datatracker.ietf.org/doc/html/rfc7489> as "v=DMARC1" with optional whitespaces. This can lead to cases when a DMARC of a domain is not set up correctly (e.g. "v=DMARCv1") and zdns' result status is "NOERROR" even though the DMARC configuration is not valid. Is it an intentional behviour? Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#252>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABREUAMZSCNLSG5WDEWYFDUEGT4VANCNFSM5E5HCBTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[bayerhonza]

Sure, I will submit the request ASAP.