zth/vscode-graphiql-explorer

Not working with vscode workspaces

benadamstyles opened this issue · 3 comments

Thanks for creating this! Looking forward to using it.

Unfortunately it's not able to find my schema, which is at the root of one of the workspaces in my multi-workspace vscode project. A quick google found this: microsoft/vscode#39625, which suggests that vscode.workspace.rootPath is deprecated.

zth commented

Hey, thanks for reporting this!

I have a few thoughts here - I've been thinking about moving to simply resolving root from finding the closest package.json, going up from the current file. This would support monorepos as well, where the schema may be at the workspace root, but also possibly below or above it.

Would resolving via closest package.json (going up the tree) resolve the issue for you too?

zth commented

@benadamstyles any chance you could give 1.3.0 a spin and see if that fixes your workspace issues?

almost 2years later,
Peek 2022-04-07 15-25